Frank Steffahn

Results 90 comments of Frank Steffahn

You could add something like ```haskell numValToFloat :: NumVal -> Float numValToFloat (Float f) = f numValToFloat (Integer i) = fromInteger i ``` to make all the other functions a...

The failing clippy lints are unrelated to this PR.

Older compiler version apparently fails in one of the dependencies (`half`).

@vorner I’ve addressed the unrelated CI failures (I don’t know if that’s the "proper" way to do this with the dependencies for 1.45 compilation, but it seems like it works);...

> are there any cases left where it is necessary? as already noted over in #77: > the actual `AccessConvert` is somewhat more general, as it allows – say –...

Thanks for the ping. I didn’t misunderstand, but I haven’t written the docs yet either; I’ll try to allocate some time to this soon :-)

> and it’s not even a breaking change I mean, one might think it is because the blanket impl gets more general with the added `?Sized`; but since rustc doesn’t...

The idea seems (probably) sound to me. But it might be a bit much new API for fairly little benefit (saving a single allocation). It’s also quite `Arc`-specific (without declaring...

There’s also UB in the proposed implementation, if it is called with slices [like this (playground)](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=7b663101329adc698e7b527c4af771b3).