Stefan Talen

Results 21 comments of Stefan Talen

Was working on a change because I encountered something similar: https://github.com/rectorphp/rector-symfony/pull/588 Looks like that will not fix your issue. Lets elaborate on a solution @TomasVotruba @samsonasik @CMH-Benny 1. Ignore when...

> single rule should handle single purpose, on this case, should be skipped if the `AsEventSubscriber` present. The purpose of the rule is to convert a Listener to an EventSubscriber,...

Converting an EventListener to an EventSubscriber and replacing EventListeners with `#[AsEventListener]` are two seperate things (with their own use cases). I'll see if I can wrap up my PR within...

Hold your horses 😬 I need to work on the `denyUnlessGranted()` implementation

I'm looking for the right return type to get from a `MethodCall` ```php $this->denyAccessUnlessGranted(['ROLE_USER', 'ROLE_ADMIN']); ``` To ```php $this->denyAccessUnlessGranted('ROLE_USER'); $this->denyAccessUnlessGranted('ROLE_ADMIN'); ``` Using the current `processExtractIsGranted`, the result is ```php $this->denyAccessUnlessGranted('ROLE_USER')...

Looking at the current sets (5.0 and 6.0), there a separate sets (`config/sets/symfony/symfony50-types.php` and `config/sets/symfony/symfony6/symfony-return-types.php`) with the type changes which is imported in the actual version set. Not sure with...

> Deprecate CacheableSupportsMethodInterface in favor of the new getSupportedTypes(?string $format) methods I don't think this deprecation can be automatically refactored, implementing `getSupportedTypes()` requires specific application information > The getSupportedTypes() method...

@javaDeveloperKid I've added [a fixture](https://github.com/rectorphp/rector-symfony/pull/360) mimicking your example, there were no changes needed to the rule. Can you confirm this issue is resolved?