Stefan Talen

Results 21 comments of Stefan Talen

Are you applying some kind of coding style? If not, I'd be willing to make the bits of code that you've finished in this PR compatible with PSR-2. I'm not...

Looks like I can create a new PR based on the branch `API-v2`, for the file structure you could use PSR-4 since it already kind of has that structure now...

Looks like a Symfony Bundle should have a recommended structure: http://symfony.com/doc/master/cookbook/bundles/best_practices.html I guess there is no need for a `src` folder then.

@miguel250 I'm not considering the symfony/symfony as a pure bundle so I'm not sure if that applies to the structure. In the end it doesn't really matter that much, let's...

@miguel250 The `composer.lock` file should not be ignored https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file

@miguel250 Makes sense :+1:

According to the [documentation](https://mailchimp.com/developer/api/marketing/list-members/add-member-to-list/), `marketing_permissions` should contain an array of objects. Looks like you are sending an array of arrays. Edit: Just came across this myself. Here is a nice...

@t3Golden Did you figure this out?

@dmishh If this is unexpected behavior shouldn't it be fixed? /cc @schmittjoh