Stefan Prodan

All Flux CRDs expose a common set of metrics, we'll need an RFC to introduce custom metrics for each controller and what's the value in doing this in regards to...

> One helm-controller for most of our clusters would not be able to reconcile everything properly. Have you tried setting `--concurrent=100`, this should make helm-controller perform 100 installs/upgrades in parallel....

@kvandenhoute what you've described sounds like a memory leak, if 1K HRs are installed in 20 seconds, but then the controller runs into OOM after half hour makes me think...

The Terraform Kind is not an a Flux CRD, if you want to enable notifications for 3rd party controllers see https://fluxcd.io/flux/cheatsheets/bootstrap/#enable-notifications-for-third-party-controllers

@k0da you can run a `kubectl patch` for each patch in https://fluxcd.io/flux/cheatsheets/bootstrap/#enable-notifications-for-third-party-controllers, this is not only about adding Terraform to the CRD, but also about RBAC.

> Wouldn't it be easier to relax validation here? The validation is only half the problem, notification-controller needs to have read access to that Kind at cluster level too. We...

Are you using the latest version of Flux? If not get the latest and see if it fixes the issue for you.

It deletes the object because of `force: true`, the Kubernetes API returns the same error as for immutable changes.

Looks like main brach is broken as well: ``` --- FAIL: TestGitRepositoryReconciler_reconcileSource_authStrategy (29.15s) --- FAIL: TestGitRepositoryReconciler_reconcileSource_authStrategy/SSH_with_password_protected_private_key_secret_makes_ArtifactOutdated=True (25.77s) --- FAIL: TestGitRepositoryReconciler_reconcileSource_authStrategy/SSH_with_password_protected_private_key_secret_makes_ArtifactOutdated=True/libgit2 (19.21s) gitrepository_controller_test.go:543: expected []v1.Condition{v1.Condition{Type:"FetchFailed", Status:"True", ObservedGeneration:0, LastTransitionTime:time.Date(2022, time.October, 11, 15,...

Ok we can ignore the panic then, it's not something we can fix in this PR.