notification-controller icon indicating copy to clipboard operation
notification-controller copied to clipboard

Add Terraform event source kind

Open k0da opened this issue 2 years ago • 2 comments

Signed-off-by: Dinar Valeev [email protected]

k0da avatar Oct 15 '22 13:10 k0da

The Terraform Kind is not an a Flux CRD, if you want to enable notifications for 3rd party controllers see https://fluxcd.io/flux/cheatsheets/bootstrap/#enable-notifications-for-third-party-controllers

stefanprodan avatar Oct 15 '22 14:10 stefanprodan

Sorry, I don't have kustomize controller deployed. Wouldn't it be easier to relax validation here? It is a little bit an overkill to add a new type.

k0da avatar Oct 15 '22 14:10 k0da

@k0da you can run a kubectl patch for each patch in https://fluxcd.io/flux/cheatsheets/bootstrap/#enable-notifications-for-third-party-controllers, this is not only about adding Terraform to the CRD, but also about RBAC.

stefanprodan avatar Oct 20 '22 08:10 stefanprodan

Wouldn't it be easier to relax validation here?

The validation is only half the problem, notification-controller needs to have read access to that Kind at cluster level too. We have no plans on given this controller cluster-admin, or allow it to read any random object from the cluster.

stefanprodan avatar Oct 20 '22 08:10 stefanprodan

@stefanprodan but this can be fixed on tf-controller side. A chart can bring a role and binding.

k0da avatar Oct 20 '22 09:10 k0da