notification-controller
notification-controller copied to clipboard
Add Terraform event source kind
Signed-off-by: Dinar Valeev [email protected]
The Terraform Kind is not an a Flux CRD, if you want to enable notifications for 3rd party controllers see https://fluxcd.io/flux/cheatsheets/bootstrap/#enable-notifications-for-third-party-controllers
Sorry, I don't have kustomize controller deployed. Wouldn't it be easier to relax validation here? It is a little bit an overkill to add a new type.
@k0da you can run a kubectl patch
for each patch in https://fluxcd.io/flux/cheatsheets/bootstrap/#enable-notifications-for-third-party-controllers, this is not only about adding Terraform to the CRD, but also about RBAC.
Wouldn't it be easier to relax validation here?
The validation is only half the problem, notification-controller needs to have read access to that Kind at cluster level too. We have no plans on given this controller cluster-admin, or allow it to read any random object from the cluster.
@stefanprodan but this can be fixed on tf-controller side. A chart can bring a role and binding.