Stefan Holm Olsen
Stefan Holm Olsen
@valdisiljuconoks This is WIP to show the idea early on. Is this refactoring fine by you? Note: test cases are not yet updated.
Isn't it okay to override the whole repository class? That way we are using the default service container. With the CQRS model, it seems to require a custom resolver.
@valdisiljuconoks Is it not open enough for overrides when it is in a service backed by a public interface?
@hangy Looks like a good optimization. But is there a way to fill in the properties that avoids converting to and from JSON?
I guess it could be filled in with Reflection. Sort of like how Newtonsoft.Json fills in properties on an object. Like: 1. Create an object from type parameter. 2. Iterate...
@valdisiljuconoks I think I cracked the case on replacing JSON conversion with reflection. It is still rather crude code, and it is not yet benchmarked. But it passes all the...
You are right about the unit tests. They are not a full proof. Can we do a prerelease NuGet (marked so solutions doesn't auto-update)? Then I could test with a...
If you do a version 9, then I would suggest to: - Change TypeFactory to regular dependency injection. It seems to allocate too much memory. - Optimize ResourceKeyBuilder further. -...
@valdisiljuconoks Do you want me to merge this PR into a v9 branch instead of master? It could also be nice to look into the data layer, like test the...
@valdisiljuconoks Yes, I will test on Optimizely CMS 12.