stefan fluck comments

Results 32 comments of


                                            stefan fluck

add src_bldg_height in ini file and make_static.py

That's actually a good idea, and not that much effort i believe. Will be taken up for the next release. cannot promise though when that is ready, the weather is...

ImportError: /lib/x86_64-linux-gnu/libp11-kit.so.0: undefined symbol: ffi_type_pointer, version LIBFFI_BASE_7.0

Hi gael sorry for the very late reply! To me that looks like it could be an issue with the gdal installation on your end. See also my reply to...

if errors occur during static driver generation, put them in the parameters.txt output

#71 is related.

typo in yres

you are right. As it is now it currently can only handle xres=yres. Changing the typo in line 111 as mentioned works, but only when still using xres=yres. Using xres!=yres,...

Check if everything works using LULC_down_unige_2018 input data and document if it does

code line 405: if supplied bb file (bodenbedeckung) is tiff, it just skips gdt.rasterandcuttlm function which rasterizes the shp. I'm a genious, so it should just work! But still test...

mst.setalbedovalue() can be extended with a "v","p",w" flag to be valid for any surface type

is this somehow related to #25 ? not entirely, since this is about setting albedo values. but, the flag idea could be useful? however, this represents an "edge" case and...

cleanup phase with buildings: line 611: hardcoded building_type values is not good. building types > 10 cannot be used

in section "l705 #where building_type is set, do not set a vegetation type or pavement type"

Implement warning if multiple building polygons have same ID

think about how this could be done, without loading the file first... but, if input files shall be sanity checked, a lot more should be checked... e.g. also #67

Allow direct input of AV data

still a good idea test if implementation of "surf_data_mode" works as expected (in code it says "not tested yet", but I surely tested it...)

building_pars can all be set, palm so far only supports index 0-46 to be set by building_pars

Apparently, this was fixed on the PALM side - test it though if it really works.