Stefan Berger

Results 172 comments of Stefan Berger

I will remove the warning print-out. It will become a hidden feature of swtpm then to send TPM2_Shutdown when needed. ``` $ ./test_tpm2_probe Need to be root to run test...

> Looks good otherwise. It would be nice to have a test for it, and some quote of the specification It will become silent. And for RHEL I would recommend...

I have looked into how to trigger the DA counter to increase upon reset but couldn't figure it out so far...

In the end there's one concern that I have about this series and that is that we accidentally send a TPM2_Shutdown(SU_CLEAR) after a TPM2_Shutdown(SU_STATE) was issued. The relevant scenarios to...

I did some more tests with suspend-to-ram (systemctl suspend) with EDK2. Here the Linux drivers sends TPM2_Shutdown(SU_STATE) and then a TPM2_GetRandom() is sent to the TPM 2 before the VM...

> I did some more tests with suspend-to-ram (systemctl suspend) with EDK2. Here the Linux drivers sends TPM2_Shutdown(SU_STATE) and then a TPM2_GetRandom() is sent to the TPM 2 before the...

Once I have confirmation that this patch resolves the issue presented in the bugzilla I will merge it.

I was planning to merge this later this week unless there are comments or concerns.

I am wondering whether to add a flag `--flags auto-shutdown` to enable this feature.

> Perhaps the other way around (disable-auto-shutdown), if we believe the new behavior is a fix and it doesn't break migration etc. I don't think it breaks anything. It rather...