steamraven

With the new format, I was going to take a stab at Trust on First Use For security reasons, I think the pattern should be very restricted, be derived from...

It appears that although request_handling.py defines functions for coroutine spawning from a pool: coro_spawn, nothing actually uses it. I think the best place for this would be in recv_forever_ever in...

Appears the filters.common_filter_test.py makes use of testing.pugins.register_plugin. This contextmanager relies specifically on get_mapping_from_secret_type_to_class having an lru_cache. It actually inserts plugins into the cache. These of course get purged by my...

I have manually tested with the minimal plugin and baseline and it fixes the issue. I have and ran pytest with "time python -m pytest tests" . I have not...

I have replicated with a minimal plugin: minimal.py: ```from typing import Generator from detect_secrets.plugins.base import BasePlugin class Nothing(BasePlugin): secret_type = 'Nothing' def analyze_string(self, string: str) -> Generator[str, None, None]: yield...

Also, with my more useful plugin. This does not seem to be plugin specific, but a race condition in the code to search for plugins themselves. ip_detector.py: ``` import re...

That pr does not fix it. I generated a baseline using the minimal.py plugin on a folder containing just the plugin itself. The only secrets are "Secret Keyword" and "Nothing"....

Here is my baseline: https://gist.github.com/steamraven/8005a93f539ebb9fa25ece4ac9d7a878

`main.parse_args` calls `ParserBuilder.add_console_use_arguments` `add_console_use_arguments` adds `baseline.parse_args` to `self._post_processors` `main.parse_args` calls `ParserBuilder.parse_args` `ParserBuilder.parse_args** calls all the `self._post_processors`, which includes `baseline.parse_args` -- Note that `baseline.add_baseline_option` is called on the "scan" subparser, but...