starry-osean comments

Results 4 comments of


                                            starry-osean

Cannot enter tax rate with decimal values (comma or dot); validation errors not localized

Hey @thochoertler , I’ve raised PR https://github.com/vendure-ecommerce/vendure/pull/4017. could you take a look and let me know if everything looks good?

Cannot enter tax rate with decimal values (comma or dot); validation errors not localized

@dlhck You are right, this bug happens in the new Admin Dashboard. I’ve reverted the previous changes to the legacy Admin UI, and moved the fix to [packages/dashboard/src/app/routes/_authenticated/_tax-rates/tax-rates_.$id.tsx](cci:7://file:///e:/kai/vendure/packages/dashboard/src/app/routes/_authenticated/_tax-rates/tax-rates_.$id.tsx:0:0-0:0) instead.

fix(dashboard): Support localized decimal separator in tax rate input

I have read the CLA Document and I hereby sign the CLA

fix(dashboard): Support localized decimal separator in tax rate input

@michaelbromley .Thanks for the review! I’ve addressed both concerns: 1. Removed the Chinese comments; everything is now in English. 2.Implemented localized decimal handling in the shared `NumberInput` (text input with...