Stanley Su

Add feature to disable image crate's jpeg-rayon for wasm compatibility

1

Loading JPEGs with `xobject::image_from` in WASM code causes a panic (e.g. https://github.com/image-rs/image/issues/1496), as there isn't multithreading in WASM now and `xobject::image_from` uses `image`, which uses rayon for JPEG loading. Could...

For visibility/accessibility improvements.

Code readability can be improved by more intuitive variable names and/or comments.

Add `#![forbid(unsafe_code)]` to ensure everything is implemented in 100% safe Rust, and mention this in the README.

Scramble parser should return Result

1

https://github.com/V-Wong/CubeSimRS/blob/92ffac3c08fb3214013b29a1dd8cc495d4637855/src/scramble_parser.rs#L47 Should return Result instead of panicking, as the user can handle the error better.

Fix tense inconsistencies in doc comments

1

I see some inconsistencies in tense (present and past) in some doc comments (currently detected in generic_cube.rs). E.g. ```rust /// Maps over the pieces of the cube, replacing each piece...

Now that this is a single argument function, I believe you can extract this function and implement it as part of the ``From`` trait. _Originally posted by @V-Wong in https://github.com/V-Wong/CubeSimRS/pull/63#r733307480_

If a move's `n` value was passed when checking if a sticker satisfies the predicate, the predicate field can become `pub predicate: fn(&Sticker, u32) -> bool>`, which is potentially cleaner/faster...

Refactor GeoCube with unsigned integers

1

The implementation of GeoCube currently features many `i32`s, where `u32`s would be more appropriate, such as the [size](https://github.com/V-Wong/CubeSimRS/blob/efa402db7500fbc5057a75c29b64dd1379d270c8/src/geometric_cube/cube.rs#L19) field in the GeoCube struct, and other mentions of size as a...