Stanislav Levin

`test_invalid_choice` and `test_explicit_cmd_name` fail due to https://github.com/python/cpython/commit/097801844c99ea3916bebe1cc761257ea7083d34. The expected message would be `'%(message)s' -> 'argument %(argument_name)s: %(message)s'` (see argparse.ArgumentError). So, the assertions could be changed to something like `assert 'invalid...

`test_set_default_command_when_subparsers_exist__supported` and `test_add_subparsers_when_default_command_exists__supported` fail due to https://github.com/python/cpython/commit/a18d52269ab6071a605d6c72f6af585a4c533ca4 (Python 3.9.8) which was reverted in https://github.com/python/cpython/commit/587ff7f50bcbfd8346c6d5db459a1628a350c04d (Python 3.9.9).

this helps for 389-ds having old and new behavior: ```diff diff --git a/pki-core/base/server/src/com/netscape/cmscore/apps/CMSEngine.java b/pki-core/base/server/src/com/netscape/cmscore/apps/CMSEngine.java index e89a691d2..e652e1c3b 100644 --- a/pki-core/base/server/src/com/netscape/cmscore/apps/CMSEngine.java +++ b/pki-core/base/server/src/com/netscape/cmscore/apps/CMSEngine.java @@ -169,9 +169,8 @@ public class CMSEngine implements ServletContextListener...

Actually, `NO_SUCH_OBJECT` is used in: ``` base/acme/src/main/java/org/dogtagpki/acme/database/LDAPDatabase.java: e.getLDAPResultCode() != LDAPException.NO_SUCH_OBJECT base/acme/src/main/java/org/dogtagpki/acme/database/LDAPDatabase.java: if (e.getLDAPResultCode() == LDAPException.NO_SUCH_OBJECT) { base/ca/src/com/netscape/cms/servlet/admin/PublisherAdminServlet.java: if (ex.getLDAPResultCode() == LDAPException.NO_SUCH_OBJECT) { base/common/src/main/java/com/netscape/certsrv/ldap/LDAPExceptionConverter.java: case LDAPException.NO_SUCH_OBJECT: base/server/python/pki/server/deployment/pkiparser.py: except ldap.NO_SUCH_OBJECT: base/server/python/pki/server/pkispawn.py: except...

@edewata, any thoughts?

According to the DS issue I provided above the released versions included this change: - 389-ds-base-2.0.3 - 389-ds-base-1.4.4.13 - 389-ds-base-1.4.3.19 If talk about Fedora, then Release | Stable version |...

@abbra, my proposal is the general refactoring pattern which will work in either case. I'm afraid that DS change has many hidden bugs in dependent projects. Just for example, ldapjdk...

Original issue has gone, but the potential ones we talked about are not fixed. @jmagne, thank you!

@ckelleyRH, the original issue was fixed, but some related issues (not exposed yet?) may be here (per https://github.com/dogtagpki/pki/issues/3458#issuecomment-779755566).

I confirm that this patch fixes `test_ds_configcheck_passwordstorage` against 389-ds-2.2.3.