Dominique Schuppli

Results 114 comments of Dominique Schuppli

Of course it _can_ be added. And of course it's also entirely possible to add and deprecate it soon thereafter. I'm just not sure if it's worth the time to...

@tonyhallett, I realise that – but this isn't just about how easy it is _for you_ to prepare a PR. There is also work involved in having this discussion /...

> it is _you_, that has these responsibilities and tasks. This is an open source project and I am not getting paid a single dime for my work here, so...

Just as a quick heads up, I am no longer helping maintain Moq (I left the team many months ago) so I won't follow up on this issue (nor others)...

There was another issue a few years ago about caching expression trees to improve performance; IIRC, that was one of the reasons that led to the `ExpressionCompiler` extension point. You...

@peterder72, I see. My apologies for the misunderstanding. Looks like a reasonable change to make. :+1: The only thing I'm left wondering is whether compiling the expression tree once, ahead-of-time...

@peterder72, I was mostly thinking about things like: ```csharp var obj = ...; ... It.Is(x => x == obj) ... // ^^^ // when / how often does this captured...

> it ought to be pretty easy to add `CallBase` support when setting up a Sequence on a `void` method. Agreed, it should be fairly straightforward. > Can you see...

Interesting. I can't tell you right away *why* that happens, but I can tell you that the problem happens in the infrastructure below Moq, not in Moq itself. I've opened...

I closed this too early... sorry. Let's close this once we've updated to a new version of DynamicProxy that contains a fix for this.