Sergei Taguer

Results 22 comments of Sergei Taguer

Oh, this looks like a good improvement, thanks! I have a couple of points: 1. This avoids traversing rootView -> nonLayoutKitView -> otherLayoutKitViews, right? What if we had rootView ->...

I think this qualifies as a bug, thanks for reporting, @moshegutman . I noticed that we have `roundedUpToFractionalPoint` in `CGFloatExtension.swift`, that would make smaller adjustments to the rectangles. Another issue...

Thanks for the report!

@plamenterziev We can definitely mention this issue in the layout's documentation comments. Do you know of a way to come up with an exhaustive list of such issues? In the...

The size is about a screen-full or more and includes expensive views such as UITextView. According to profiling, much of the time is spent in makeViews, either constructing UIView instances...

Apologies for the delay, @fmirault . I added a comment. This adapter is used for both table views and collection views, so it'd be odd to have a property that...

We tend to capture the reference in the `configure` block, but that code predates `viewReuseId`. Let us know which pattern ends up working better for you or if we can...

We're considering adding a return value to the makeViews method. It would return a dictionary of layouts to the corresponding views after the view creation finishes. The collection / table...

@inamiy I'm looking at Test playground page in inamiy/LayoutKit playground branch. Are you referring to the behavior of the Hello/World label that doesn't have a viewReuseId? Is the problem that...

Yes, this sounds like a fair point. This isn't a problem that we've run into ourselves, so I hesitate to suggest additions to the library just yet. Let me know...