sot-core icon indicating copy to clipboard operation
sot-core copied to clipboard

fix thread_interruptible_loop

Open nim65s opened this issue 4 years ago • 2 comments

Ok but what about this file? import dynamic_graph.sot.core.utils.thread_interruptible_loop It basically get's an error because it imports: from dynamic_graph.script_shortcuts import optionalparentheses Which in essence is not Matlab stuff. So I guess another PR in dgp is needed to remove the Matlab stuff but I cannot do it from this PR. This is why I disabled the unit-test from now.

Please let me know if you both (@jmirabel and @nim65s) are ok with this PR.

This is coming from dynamic-graph-python. It used to be a way to directly test the SoT from a python interpreter.

I am attempting a revival of this part, mostly to have the SoT independent from ROS.

Originally posted by @olivier-stasse in https://github.com/stack-of-tasks/sot-core/issues/172#issuecomment-726889417

nim65s avatar Nov 13 '20 19:11 nim65s

I am testing that if removing .matlab is enough. My guess is that it is.

olivier-stasse avatar Nov 14 '20 09:11 olivier-stasse

Thanks @nim65s for opening this issue.

olivier-stasse avatar Nov 14 '20 09:11 olivier-stasse