pinocchio icon indicating copy to clipboard operation
pinocchio copied to clipboard

fix windows ci

Open fabinsch opened this issue 1 year ago • 3 comments

On Windows, ensure proper handling of both cl.exe and clang-cl.exe. Previously, our setup did not use clang-cl.exe.

fabinsch avatar Aug 29 '24 14:08 fabinsch

clang-cl doesn't seem to like some boost::archive stuff

ManifoldFR avatar Aug 29 '24 15:08 ManifoldFR

clang-cl doesn't seem to like some boost::archive stuff

Indeed, this is related to a current issue on conda-forge that @fabinsch is now fixing :)

jcarpent avatar Aug 29 '24 16:08 jcarpent

Similar to our conda-feedstock, we now get a linker error on Windows with clang-cl.

Not setting the CMP0167 policy, e.g. removing this commit, results in a lot of warning but allows to compile and link on windows with clang-cl.

fabinsch avatar Aug 29 '24 16:08 fabinsch

@fabinsch could you push your fix here?

jcarpent avatar Aug 29 '24 16:08 jcarpent