pinocchio icon indicating copy to clipboard operation
pinocchio copied to clipboard

[Spatial.9] Suffix all CRTP method implementation by _impl ...

Open jcarpent opened this issue 8 years ago • 3 comments

I think it is a good strategy to avoid infinite loop and decrease debugging time. I would also suggest to set all those methods protected to force the user to use standard C++ operators and to let the compiler solve the computation tree.

jcarpent avatar Jun 22 '16 10:06 jcarpent

I agree that this is necessary. We should have a single commit to propagate this change systematically in all the code (mostly spatial and joint modules). Anybody would volunteer to do it?

nmansard avatar Jun 23 '16 07:06 nmansard

If nobody has started it, i can do it

fvalenza avatar Jun 24 '16 08:06 fvalenza

I just realised that it is not possible to set methods with *_impl suffix protected. Or, one should use some back door to do that which leads to unreadable code.

In Eigen, they used some tricks to compile an API which fits pretty well for doxygen but which does not correspond to the real API, in terms of implementation. But I think the code will become very hard to read and maintain to.

Maybe the best thing for a clean API is to resort on gdb during the debug process ...

jcarpent avatar Jul 06 '16 23:07 jcarpent