eigenpy icon indicating copy to clipboard operation
eigenpy copied to clipboard

Published 20 hours ago • verified publisher icon stack-of-tasks

Add support of numpy 2.0.0b1

Open duburcqa opened this issue 11 months ago • 3 comments

Fixes https://github.com/stack-of-tasks/eigenpy/issues/447

It requires a follow-up PR in Boost::Python itself here, but it does not prevent from merging this PR.

duburcqa avatar Mar 15 '24 13:03 duburcqa

@duburcqa Thanks for the contribution to support the latest NumPy change. Yet, it seems important to first extend the support of EigenPy, then change some variable names if they improve the readability. Please make these two stages into two different PRs.

jcarpent avatar Mar 15 '24 14:03 jcarpent

I will fix support of Python < 3.9 due to unsupported Py_SET_TYPE.

duburcqa avatar Mar 15 '24 14:03 duburcqa

The CI is passing !

duburcqa avatar Mar 15 '24 20:03 duburcqa

Thank you both for your hard work here! 🙏

Am curious, when building wheels for 3.5.0 or 3.5.1, were they built with NumPy 1 or 2?

jakirkham avatar May 31 '24 00:05 jakirkham

Numpy 1, there is still work to do to fully support numpy 2 in pre-compiled binaries.

duburcqa avatar May 31 '24 05:05 duburcqa

Ok thanks Alexis! 🙏

jakirkham avatar May 31 '24 07:05 jakirkham