eigenpy icon indicating copy to clipboard operation
eigenpy copied to clipboard

Published 20 hours ago • verified publisher icon stack-of-tasks

WIP: Copy std-vector and std-map from Pinocchio

Open ManifoldFR opened this issue 3 years ago • 2 comments

I recovered the history using git-filter-repo, squashed and rebased it into a single big commit before merging the files' history into eigenpy.

TODO

  • Include the utils/copyable.hpp header from Pinocchio
  • Include the relevant tests

Closes #324

ManifoldFR avatar Oct 04 '22 14:10 ManifoldFR

Hi ! This project doesn't usually accept pull requests on the main branch. If this wasn't intentionnal, you can change the base branch of this PR to devel (No need to close it for that). Best, a bot.

hrp2-14 avatar Oct 04 '22 14:10 hrp2-14

@ManifoldFR Thanks a lot for this PR. Could you remove aligned_vector, which is not useful to have I do think?

Ok, will do so

ManifoldFR avatar Oct 04 '22 17:10 ManifoldFR

Rebased on devel.

ManifoldFR avatar Nov 25 '22 15:11 ManifoldFR

Now it should be fixed. I will manually squash my commits and force push.

fabinsch avatar Dec 05 '22 14:12 fabinsch

Nice work @ManifoldFR and @fabinsch. Thanks a lot.

jcarpent avatar Dec 05 '22 18:12 jcarpent