Markus Staab

Results 889 comments of Markus Staab

As far as I remember I used default settings / not sure whether this means compressed or not

committed another small micro optimization, which also improves readability a bit

@EmilMassey do you have an opinion on this feature request?

> I think it's a very good idea. I like the suggestion to always detect issues when referenced with full URL, regardless of the configuration. When it's implemented, developers in...

hey, its not yet possible. I think it would be a good idea though to optionally report invalid TODO comments.

hmm thinking again about it.. most comments usually not have a expiration and forcing people to write a expiration condition sounds like a frustrating experience

> to prevent it to break PhpStan if this behavior is not wanted? could you elaborate on how this "breaks phpstan"? > Why not making this an option disabled by...

In my experience you also need to set a proper php.ini in the github action. See e.g. https://github.com/nikic/PHP-Parser/commit/f2e037f8ea4c4bac1a5a36b4d8334f2aa581491a

grml.. blackfire reported a 30% faster execution, but doing some final tests without a profiler makes me sad as the profiled improvements don't show up without a profiler. I think...

@Wirone I wonder whether a PR which reduces function calls would be acceptable - even if it does not improve performance and create a bit of class-internal code duplication -...