Markus Staab

Results 889 comments of Markus Staab

in the meantime I will merge the phpstorm workaround from https://github.com/staabm/phpstan-dba/pull/454, but I would love to dig into this more with a reproducer

> However, in `QueryPlanAnalyzerRule::analyze`, the `$queryArgPosition` is not used, and it assumes that the query string is the first argument, and the parameters are (optionally) the second argument. you are...

see https://github.com/phpstan/phpstan-src/pull/2096

It doesn't work yet with stubs from phpstan-src only. I don't know yet how we can make this error go away. If you got this error, you can proceed like...

> in the CI it will fail all the time, cause the result cache isnt existing You should enable the result cache in CI. It saves a lot of time....

maybe also in [rexstan](https://github.com/FriendsOfREDAXO/rexstan)

leaving `#[\ReturnTypeWillChange]` in for a bit so we have wider php version support should be the way to go in my opinion. does `#[\ReturnTypeWillChange]` incur a problem as you are...

since 7.x is still part of LTS linux distributions, I would give them more time. if we have a concrete problem to solve, because of PHP7 support we can re-discuss....

btw: I am cooking up a alternative to this PR which consists of a fix in the exporter instead

@sebastianbergmann I just saw you rebased this PR. do you have any new insights to share?