Steve

Removal of default css styles?

8

## I would like to see... 🙋‍♀️🙋‍♂️ Removal of default css. ## Why and how 💬 I noticed that the included default styles was causing issues when using this addon...

When there is no addEventListener on windows (might happen with server side rendering running in node), this lib throws an exception. This PR adds a check if `addEventListener` is available....

modifier: handle renders as draggable when dragging is disabled

3

For the modifier version there currently wasn't a way for a draggable elements to know when dragging is disabled. This PR adds the attribute `data-sortable-disabled=true` to the sortable item. Additionally...

**Describe the bug** If the sortable elements have different margins, ember-sortable calculates the height of the elements incorrectly, which collapses all margins. **To Reproduce** Use the following css to apply...

Migration guides are broken

1

https://adopted-ember-addons.github.io/ember-sortable/MIGRATION_GUIDE_V2.html **Screenshots**

2.2.0: massive bundle size increase

7

**Describe the bug** The bundle size for `2.2.0-beta` almost doubles compared to `2.1.3`. ember-cli-bundle-analyzer lists the following sizes added to vendor.js `5.4kb` version `2.1.3` `10.3kb` version `2.2.0-beta` I think this...

non json response

6

Is there a nice way to handle non json responses, like binary data or an empty response body? As for binary data, tampering with the underlying xhr works, but hasn't...

is it possible to disable routeAfterAuthentication?

1

For scenarios where login is handled via a modal, there is often no need to transition to a different page after authenticating. Rather than it would be beneficial to be...

using HttpOnly cookies

6

I was thinking about improving security when making use of the cookie store and was wondering if we could make use of HttpOnly cookies when using ember-simple-auth, and it seems...

add Access-Control-Allow-Credentials header

2

fixes #415