Steven Soroka

Results 55 comments of Steven Soroka

I don't think so. It's for image manipulation. I'll double check

Ok, I checked into this and I am using github.com/nfnt/resize and github.com/disintegration/imaging , which both use goroutines. The above stack trace is the only one I get on panic, though....

So if we add a mutex over the whole thing it should be okay. I can test that out.

I tried adding a `mutex.Lock()` `defer mutex.Unlock()` just before that block. It seemed to help, but it did eventually fail with the error from https://github.com/dvyukov/go-fuzz/issues/146

I'm not explicitly overriding GOMAXPROCS. I'll review all the code I'm importing to confirm. I don't think it's good enough to say "go-fuzz shouldn't use multiple processs", because the library...

FYI, I'm not setting GOMAXPROCS anywhere. I could maybe build a test case that exhibits the bug. re race detection, I don't see where go-fuzz turns on race detection?

Thought maybe this was just ree, tried "ruby 1.8.7 (2010-12-23 patchlevel 330) [i686-darwin10.6.0]" too, no go.

I'm still seeing this issue in v1.1.0. Changing the width doesn't seem to have any effect.

I'm not seeing the issue at the moment, though @joefitzgerald 's suggestion seems like a reasonable one.

Looks like the bugfix is to catch `""` and return no error. Not sure why the crc method is bundled into this.