Tongzhou Wang

Results 9 issues of Tongzhou Wang

If we merge a `MISSING` field, with an `attrs` class structured config that uses default factory (e.g., for specifying defaults list in hydra), this `expand` call https://github.com/omry/omegaconf/blob/6a4fd518d53c7b9996b720458352b1e6a643e769/omegaconf/basecontainer.py#L327-L342 will call `node._set_value(attrs_class)`,...

bug

Do something like this commit: https://github.com/SsnL/pytorch/commit/8f2ddf846de095459341af4e90194ec49f819067

**Describe the bug** In the `maze2d-XXXX-v1` datasets, `rewards[t]` equals whether `observations[t]` reaches the goal. However, according to `MazeEnv` code, it should equal to whether `next_observations[t]`, i.e., `observations[t+1]` reaches the goal....

The `scaled=True` option claims to scale by tangent norm https://github.com/geoopt/geoopt/blob/47e7e6b79c177e3172161afaef8424d61b917a7b/geoopt/manifolds/stereographic/math.py#L1549 However, Euclidean norm of `a` is used https://github.com/geoopt/geoopt/blob/47e7e6b79c177e3172161afaef8424d61b917a7b/geoopt/manifolds/stereographic/math.py#L1579-L1584 Missing lambda?

good first issue

**Describe the bug** I have a DE1XL. The water level warning will go off when the water tank still has ~40% water, even if I set the water level config...