ssk97
ssk97
Oh huh the Players added are in a nondeterministic order (since they're obtained via `Set`), will have to consider how to handle that. Maybe I get a `PlayerList` and filter...
> > Oh huh the Players added are in a nondeterministic order (since they're obtained via Set) > > What code are you talking about? Xmage and rules used APNAP...
Ok, the changes to blueprint target adjusters got a bit bigger than expected now, if you'd like I can separate that into its own PR.
> If there are only refactor left (replace custom ability to standard). Then yes, it can be continue in another PR (current must contains new card and improved adjusters). This...
I noticed in #12593 is that `StaticValue`'s `getMessage()` returns `""`, so effects use `toString()` to get the actual value. Changing this behavior would break a lot of existing text generation.
> > I'm happy for anyone to work on this but I will want to review to avoid introducing too many new text discrepancies (assuming the overall paradigm is improved,...
> Interesting--i see what you're talking about (`checkWrongAbilitiesText()` in `VerifyCardDataTest.java`?) but i'm wondering why that test doesnt fail when encountering cards like in #12587. It should, if you set the...
> what lever is pulled to demote these tests to nonfatal? Maybe with the above changes we can start being more stringent about card test? When it fails it does...
I'm working on the following cards: - Anduril, Narsil Reforged - Aragorn, Hornburg Hero - Fell Beast's Shriek - Galadriel's Dismissal - Gimli's Reckless Might - Isengard Unleashed - Minas...
Looks like I caused this problem, when I added support for [[Wastescape Battlemage]]'s kicker abilities. Not sure what the best way to solve it would be, the easiest solution would...