Sasha Simic
Sasha Simic
It would be nice to add some description to the PR and share images of the diff if the changes are visual in nature,
> i worry about testability and maintainability here. it been our stance that telemetry is for diagnostic only, and there are no guarantees on stability. I'd worry if we make...
We have mostly added perf telemetry around container/loader. Would it be helpful to add general telemetry on some of the key container APIs? Container/loader seems like a common entry point....
> Duplciate PR? Or maybe for different branch? I've left comments in the other one This should be the only PR. I see your comments here. Thanks for the quick...
Some general thoughts: 1. It would be nice if we had "migration" package that essentially hides all this complexity of variations and unhappy paths that can play out with clear...
Nice work @Josmithr !! Love the attention to detail!
> Some thoughts based on reading description: > > 1. _"Our short-term solution assumes certain type of client persona - using Fluid Containers for transient real-time collaboration"_. For this scenario...
I'll lost track of this PR. I'm inclined to close it for couple of reasons: 1. Load options were included as part of the "end" event. During our OCE shift...