Shawn Silverman

Results 158 comments of Shawn Silverman

For implementations that don't use a big decimal library, since the validation will fail (`"valid"` will turn out to be `true`), is there a way to ignore these tests?

If `[true, false]` doesn't satisfy the `oneOf`, shouldn't it be considered invalid? (per https://github.com/json-schema-org/json-schema-spec/issues/810#issuecomment-581621587)

I'm assuming that closing without waiting is the preferred behaviour. Am I correct, or would you rather keep the "wait until closed" version?

I can’t speak about other libraries, but in my library, close() does the same thing as stop(), except that it doesn’t wait for the connection close to be acknowledged. As...

One more thing: stop() exists in the Arduino API but close() does not.

Agreed. This was just something I noticed that I thought you might like to consider, even if you don’t take the PR.

Egads, I can't figure out how to make an "unresolved conversation." Sorry about the noise.

This is an issue with the specification and not the DEVICE_INFO.json file.

What about testing for the existence of the key at `~/Documents/Arduino/key.pem`? That's the default path on the Mac. Or, could always use these configuration options, something like: 1. `key_location` 2....

I don’t disagree with you there. I always err on the side of “more knobs”, but you’re right. I think the main place where that kind of option might be...