rdm-schema icon indicating copy to clipboard operation
rdm-schema copied to clipboard

Published 20 hours ago • verified publisher icon ssilverman

Consistent Field Names

Open sammysmallman opened this issue 3 years ago • 2 comments

Fields duplicated across parameters should use the same "name" value. For example DEVICE_INFO contains the personality index and dmx start address, but uses different names for those fields rather than what is used in DMX_PERSONALITY and DMX_START_ADDRESS.

sammysmallman avatar Aug 02 '22 19:08 sammysmallman

This is an issue with the specification and not the DEVICE_INFO.json file.

ssilverman avatar Aug 23 '22 05:08 ssilverman

I agree this is an issue with the specification and inconsistent verbiage. But we can't let that roll into code. The name is used to uniquely identify one parameters field from another and in this situation a user of the schemas may not only be trying to keep their localisation files DRY but using the unique id's to correlate duplicate fields across parameters.

sammysmallman avatar Aug 23 '22 09:08 sammysmallman