Siddhant Shekhar

Results 9 comments of Siddhant Shekhar

Segfault with --asm when accessing calldata array of internal function types

Can i take this issue?

[6.1] Add CachingFormFactory and CachingUserFactory with DI provider (BC-safe caching)

Thanks for the heads-up, @richard67 I’ve fixed all reported code style issues and pushed the updated changes. The php-cs-fixer and phpcs checks should pass now.

[6.1] Add CachingFormFactory and CachingUserFactory with DI provider (BC-safe caching)

Thanks for the feedback. I’ve manually reviewed all three files and updated them to follow Joomla’s core coding style exactly, using the same headers, method order, and formatting as other...

[6.1] Add CachingFormFactory and CachingUserFactory with DI provider (BC-safe caching)

Thank you @richard67 I appreciate you taking the time to rebase the PR to the 6.1-dev branch. I now understand that new feature-related work like this should target the 6.1-dev...

[6.1] Add CachingFormFactory and CachingUserFactory with DI provider (BC-safe caching)

Thanks for the suggestion @HLeithner that makes sense and I appreciate the direction. My current PR introduced per-request in-memory caching via decorator factories to restore the request-scoped behavior that getInstance()...

[6.1] Add CachingFormFactory and CachingUserFactory with DI provider (BC-safe caching)

Thank you for the clarification @HLeithner, I really appreciate the detailed feedback. I understand now that the preferred direction is to avoid caching factories altogether and instead handle subform reuse...

Unresolved issues with removing `getInstance()` methods

Can i take this issue ?

[6.1] Feature: Add conditional check for email form heading in com_contact default.php

Hi @richard67 , thank you for your review and feedback. You’re right on all points. I will update the PR accordingly: 1. Wrong target branch Since this is a new...

[6.1] Feature: Add conditional check for email form heading in com_contact default.php

Hi @richard67, Thank you for your detailed review and feedback! I've addressed all the issues you mentioned: ✅ **Target Branch**: Created new PR targeting `6.1-dev` instead of `5.4-dev` ✅ **Code...