Shane Smiskol

Results 295 issues of Shane Smiskol

This helped on the Acadia (https://github.com/commaai/openpilot/pull/25354), as well as the new Bolt EV/EUV where both cars have a large delay to initially start braking (similar to lateral friction we must...

tuning
car
gm

Includes old and new code (why it's only a green diff) This aims to make it easy to document and maintain the parts that come in the shop and the...

enhancement
refactor
docs
car

![image](https://github.com/commaai/openpilot/assets/25857203/66ffccfc-6193-4ee2-8878-0f7ec7dbe7c0) @maxime-desroches can you think of a better place for these, or fix the formatting?

bug
docs
car

26a38e4bf36bb74a|2023-04-20--23-55-52--3

enhancement
car
hyundai

Some kind of test that at least test it doesn't crash, right now it silently fails if the CarInfo structure changes. If the easiest solution to this issue is to...

bug
docs
car

## Bounty: Remove tedious flow of checking out the old commit, dumping the Python `CarInfo` objects to a file, and then loading it back which can break if the `CarInfo`...

enhancement
bounty
docs
car

instead of https://github.com/commaai/openpilot/pull/28214 bit more work to verify, but this should be the correct way to handle it

enhancement
car
gm

this approach might be much better than what we do now. currently, no matter how hard you press, if it's under the time period it will not register, which doesn't...