openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

GM: common longitudinal actuator delay

Open sshane opened this issue 2 years ago • 2 comments

This helped on the Acadia (https://github.com/commaai/openpilot/pull/25354), as well as the new Bolt EV/EUV where both cars have a large delay to initially start braking (similar to lateral friction we must overcome). The Escalade merged here also seems to have this same delay: https://github.com/commaai/openpilot/pull/27276

This PR adds this delay to all camera ACC cars (EVs do not have regen capabilities), and all ICE cars. The only platform this does not affect is the Volt.

sshane avatar Feb 16 '23 03:02 sshane

Our Bolt with a low delay: Screenshot from 2023-02-15 15-50-11

sshane avatar Feb 16 '23 03:02 sshane

Waiting for a Silverado (camera ACC) and Escalade (ASCM) to try this and will merge.

sshane avatar Feb 16 '23 04:02 sshane

Escalade: https://github.com/commaai/openpilot/pull/27406

sshane avatar Feb 20 '23 23:02 sshane

Silverado also has similar lag: fe80a4e1cedec853|2023-03-20--20-24-23

sshane avatar Mar 22 '23 02:03 sshane

Moving the Volt over as well, as the regen that is supposedly non-laggy isn't uniform across all speeds, and non-existent at low speeds, so the brakes are also reportedly laggy there.

sshane avatar Mar 22 '23 02:03 sshane