Scott Seago
Scott Seago
@reasonerjt I don't think I've heard this particular issue coming up. Making it configurable at install makes sense, though, as long as the default behavior (with no user setting) is...
This isn't stale -- we already have a PR opened to implement this.
@reasonerjt Hmm. So there's one thing that's still not covered by that proposal. Whether we're talking about the new design in #5333 or the current design, with cluster-scoped resources, we...
VolumeSnapshotLocations are used by VolumeSnapshotter plugins (aws, azure, gcp). The CSI plugin does not use them, since the CSI plugin doesn't interact with out-of-cluster cloud resources.
@qiuming-best Actually we should probably bump it to 1.11, since I don't expect a new restic release will be out before we release 1.10.
Now that the overall design changes have been approved, this PR is ready for review.
@blackpiglet I think there's still some disagreement and/or miscommuncation on the behavior when `include-namespaced-resources` is omitted. We had previously decided that omitting means "include nothing" to be consisten with cluster-scoped...
@blackpiglet as for the question of the implied `--include-namespaced-resources=*`, the suggestion above would also work, but we'll have to make wildcards work on exclude. Currently, they only really work properly...
@blackpiglet @jglick Just a note, we've not yet implemented this for volumesnapshotter plugins (native aws, gcp, azure snapshots), but it is available for BackupItemAction/RestoreItemAction plugins as of 1.11, and will...
Now that the overall design changes have been approved, this PR is ready for review.