velero icon indicating copy to clipboard operation
velero copied to clipboard

Published 20 hours ago • verified publisher icon vmware-tanzu

BackupItemAction v2 design

Open sseago opened this issue 2 years ago • 5 comments

This includes necessary changes to support async item action monitoring.

This includes the design for the BackupItemAction v2 API which is to be implemented in the Velero 1.11 dev cycle.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • [ x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • [ ] Updated the corresponding documentation in site/content/docs/main.

sseago avatar Sep 22 '22 16:09 sseago

/kind changelog-not-required

sseago avatar Sep 22 '22 16:09 sseago

I'm going to update this to use the google.protobuf.Empty predefined type rather than defining my own empty message type.

sseago avatar Sep 26 '22 22:09 sseago

Can we also consider this change in BIA V2 https://github.com/vmware-tanzu/velero/issues/5274?

Lyndon-Li avatar Sep 30 '22 01:09 Lyndon-Li

@Lyndon-Li I commented on the issue you linked -- it's not clear to me what you'd like added to the interface, but if we can identify the changes required, I can include them in this design (and in the RestoreItemAction v2 design).

sseago avatar Sep 30 '22 15:09 sseago

Working through a draft implementation of this, I realized that I'm missing a couple fields in the OperationProgress struct as specified in the item action progress monitoring design. I'll update this PR shortly.

sseago avatar Oct 11 '22 19:10 sseago

Now that the overall design changes have been approved, this PR is ready for review.

sseago avatar Dec 06 '22 17:12 sseago

@dsu-igeek @ywk253100 @blackpiglet @qiuming-best @Lyndon-Li @reasonerjt Please review as time permits, thank you!

weshayutin avatar Dec 06 '22 21:12 weshayutin