Sebastian Schuberth

Quoting from #3211: > In general the license of package manifest is best collected with --package that knows about the manifest structure. I'd even argue that without `--package` files that...

@akozlova, could you please have a look at the test failures? There seems to be some Java version 17 vs 11 mismatch.

@sksamuel or @Kantis could you please have a look as well? I'm not familiar with the IntelliJ plugin API.

@sksamuel as you've already approved, is there anything blocking the merge?

I'd like to comment on this draft already, to avoid going it into an undesired direction eventually: While I agree with @nnobelis saying [here](https://github.com/oss-review-toolkit/ort/pull/10004#discussion_r2062979417) that we should not spread conditionals...

> If this makes sense, maybe we could take a iterative approach: Yes, that makes sense to me. We should start with a separate PR that generalizes the existing `FossIdSnippetReporter`...

> If you agree, I'll remove it from the current PR and create a separate one Yes, I was about to suggest that any changes to `plugins/scanners/scanoss/src/test/kotlin/*.kt` files in this...

> How would you prevent an `if` in the template and still do some conditional rendering ? Ok, that's a different case than what I had in mind. This is...

One more thought about creating a generic snippet scanner report: When doing so, I believe this should be roughly implemented by removing `plugins/reporters/fossid/src/main/kotlin/FossIdSnippetReporter.kt` and moving `plugins/reporters/fossid/src/main/resources/templates/asciidoc/fossid_snippet.ftl` to a new `plugins/reporters/asciidoc/src/main/resources/templates/asciidoc/snippet_report.ftl`.

> Yes, it's totally never going to happen IRL, but it's way cleaner IMO. Why is it cleaner if you have to (potentially) add extra code to only create a...