ssborbis

Results 328 comments of ssborbis

I think this has to do with how the shortcuts are captured and stored. KeyboardEvent.keyCode is being depreciated so developers are moving all events to KeyboardEvent.key [MDN](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode) If the same...

> First: images that opens new pages are treated like links Do you have an example?

> First: images that opens new pages are treated like links Oh wait, do you mean images that are encompassed by a link? Ok, that one is known. Let me...

The default is to use the image URL over a link URL. Not sure why you're seeing differently. Could you post your config here?

I just checked that site with my config and the default config. Both use the image URL

I think it's because you don't have images enabled in the quick menu settings ![image](https://github.com/ssborbis/ContextSearch-web-ext/assets/24310997/ccb1d689-81ee-48c1-9a76-0be5896eabd5)

Try disabling `quickMenuPreventPageClicks` I'll need to look into why exactly this happens, but that seems to be the issue.

Hmm... ok, just so we're on the same page. Using your config, as sent, I get this when double-clicking: ![before](https://github.com/ssborbis/ContextSearch-web-ext/assets/24310997/ac76ca90-7b05-4f1b-91be-69d2fdfd303c) After disabling `quickMenuPreventPageClicks`, I get this: ![after](https://github.com/ssborbis/ContextSearch-web-ext/assets/24310997/ec45b6fa-9e89-4ec2-8a99-aa781ef826fb) Are you seeing...

Ah. No, the code used to move the context menu to a double-click stays in place regardless of whether the menu is enabled on a particular type of element or...

I'll try loading it on a virtual macos install and look. Might be a few days before I get the chance.