SamareshSingh comments

Results 20 comments of


                                            SamareshSingh

Fix #187: Resolve race conditions during rapid UE registration/deregistration

@linouxis9 - Please get a chance to review this PR. Thanks!

Use core::string_view directly instead of alias

Thank you @ashtum for the review! I've updated the PR to: 1. Process example and test directories - added 58 more files with string_view replacements 2. Remove replace_string_view.py from the...

Use core::string_view directly instead of alias

Thank you for the detailed review! I've addressed all the feedback: 1. Removed the type aliases from string_type.hpp as they're no longer needed since all code now uses core::string_view directly...

Use core::string_view directly instead of alias

Fixed all remaining comment alignment issues.

Use core::string_view directly instead of alias

Why the core::string_view → boost::core::string_view change is necessary? The issue: C++ namespace lookup rules mean that when you write core::string_view in a file, the compiler searches for core starting from...

Use core::string_view directly instead of alias

@ashtum Please let me know if this PR looks good?

Fix FP8 linear layer dimension check to prevent runtime error

Can someone take a look on the PR?

feat: add OpenRC init script for Alpine Linux

> Is it possible to distribute an emqx software package based on the Alpine system?Use `apk add emqx` to install emqx. Done. Please let me know if you have further...

feat: add OpenRC init script for Alpine Linux

> Thanks. We'll discuss internally how to fix the PID file ownership problem. Sure. Please keep me posted with the idea. I am happy to contribute on this.

feat: add OpenRC init script for Alpine Linux

Tested the committed changes, and it works on Alpine as well. Thanks.