Sebastian Rühl comments

Results 105 comments of


                                            Sebastian Rühl

Textview can't get GetRegionText with colored content and panics

so from my understanding that would be solved by changing 627 to `if currentTag < len(colorTagIndices) && colorTagIndices[currentTag][1]-colorTagIndices[currentTag][0] > 2 { `

fix: fixed GetRegionText when colors are active

@rivo this is a pretty simple fix. Would be great if that could be merged as without colors can't be used in conjunction of `GetRegionText`

fix: fixed GetRegionText when colors are active

Oh sorry, somehow one of my github orgs spams so much notifications that your message didn't reach me. I will fix that ASAP. I force-pushed your suggestions.

trivy action touches ~/.config as root

``` security_scan: name: Security Scan runs-on: [self-hosted, Linux] steps: - name: Correct Trivy cache permissions run: | mkdir .config ls -la .config - name: Run Trivy vulnerability scanner in repo...

trivy action touches ~/.config as root

use a azure self hosted runner to let the action run

fix: opm collection field set value error

thanks for the PR. Can you (@fangzhengjin) please add a unit-test case for that?

Build image for `linux/arm64`

@brokeyourbike one note: I think that needs to be adjusted too, right? `ENV CGO_ENABLED=0 GOOS=linux GOARCH=amd64` https://github.com/hibiken/asynqmon/blob/master/Dockerfile#L42

Feature-Request: onSelect

as a small addon to that: this feature is used already internally for the breadcrumb navigation (just not exposed).

fix: 64-bit struct member alignment issues for sync/atomic for #158

guess it's the PR for this issue https://github.com/vmihailenco/taskq/issues/158

Structured logging

stumbled over that: https://github.com/go-logr/logr might be the best option as it's pluggable to a lot of logging framework