Shane St Savage
Shane St Savage
Looks like the GHA Dockerfile vs ERDDAP reload version difference detection isn't working quite right...
Hello! Overarching comment: PRs are always welcome! If you haven't already reviewed recent changes to datasets.d.sh, there are a few PRs that were merged just a few days before this...
Yikes, I updated the GitHub Action which builds and pushes the images so must have messed up something there. I manually pushed both platforms for `axiom/docker-erddap:2.24-jdk21-openjdk` and will look into...
I refactored GHA and believe this is now fixed. Issue was that GHA matrix approach doesn't play nice with docker multi-platform builds.
There are four test failures in the GHA test, from these three test signatures: ``` EDDTableFromMultidimNcFilesTests#testTreatDimensionsAs EDDTableFromInvalidCRAFilesTests#testBasic EDDTableFromNcFilesTests#testOrderByMean2 ``` Interestingly these all pass locally on my Linux machine with Java...
The `EDDTableFromNCFilesTests#testOrderByMean2` failure was due to `TopLevelHandlersTests` changing the value of `EDStatic.angularDegreeUnitsSet`. The order of tests is non-determinate and apparently is different on the GitHub action runner. https://github.com/ERDDAP/erddap/blob/main/src/test/resources/datasets/topLevelHandlerTest.xml#L7 Fixed that...
@ChrisJohnNOAA At long last this should be ready to go. I updated the description with notes about additional changes needed to make the tests pass (most importantly moving test data...
One other note: the total cache GitHub actions cache size for a repo is 10GB. The size of the cached data payload (everything in `~/.m2/repository` which includes all dependency jars...
Ah yeah, good point. Do you think we need to handle deletion of the previous `src/test/resources/{data,largeFiles,largePoints,largeSatellite}` through an ant task? Or exclude those directories from `testResources`? Or just try to...
> How is using test-data different that it will eliminate the flakiness? This is more of a speculation and I haven't tested, but it should make any test more stable...