Shane St Savage
Shane St Savage
Before seeing your message I've been working on using an annotation on the EDD classes to indicate their Sax handler, so that's good confirmation. Are you saying we should use...
Ok, I reimplemented this, adding support for both `fromXml` and `State` sax parser discovery using reflections/annotations.
Also, I think it should be fairly straightforward to adapt this to #205, maybe just changing the usage of `Class` to `Class` for clarity.
Good call, let's handle `GenerateDatasetsXml` changes in a separate issue.
@ChrisJohnNOAA One thing I want to check on. With the next release are we going to set a hard requirement on Java 21+? Or continue to support both 17 and...
This seems to be working well. I made the reflection based discovery configurable with a `useEddDiscovery` setting, and the Java 17 issues mentioned above seem to be resolved.
We probably also want the same behavior for test settings here: https://github.com/DataONEorg/d1_python/blob/master/gmn/src/d1_gmn/tests/gmn_test_case.py#L44 So ``` os.environ.setdefault("DJANGO_SETTINGS_MODULE", "d1_gmn.settings_test") ``` instead of ``` os.environ["DJANGO_SETTINGS_MODULE"] = "d1_gmn.settings_test" ``` ~~but I can make a separate...
@rogerdahl Do you think we could get this merged? It's currently blocking our GMN Dockerization effort, and we're hoping not to need to fork the repo for a trivial change.
Gentle bump on this one, is this ready for merge or does it need an additional review?