Scott Stevenson
Scott Stevenson
`nb-clean` removes the Python version from the global metadata by design. Do you have a specific use case where maintaining this metadata is required? > Every time that I open...
Thanks for working on this, it's looking good! The call to `mock_git.assert_called_once_with` ensures we're calling Git with the correct arguments. There isn't too much behind the use of `assert_called_once_with` instead...
That use case sounds valuable, so I'd be happy to add this. Do you want to make a PR to add a `--required` flag to the `add-filter` subcommand? Let me...
Is it worth making this `... | sudo bash`? At the moment there's no indication the installation requires superuser privileges, until it fails to write to `/usr/local/bin`.
KeePassX is popular among people I think would be interested in pick; a cursory search led to [tobischo/gokeepasslib](https://github.com/tobischo/gokeepasslib) as a Go implementation.
Hi @bneijt -- this is certainly something I'm willing to merge, if you'd like to add the option to the `check` command and some tests. 😃
@bneijt How about always expanding the arguments that are passed, and removing the `--recursive` flag? This would be consistent with what most Python linters/formatters do (all of mypy, Black, isort,...
This is now available in [nb-clean 2.3.0](https://pypi.org/project/nb-clean/2.3.0/) on PyPI.
This should already work if globs are expanded by your shell, which they typically are by default in shells like `bash` and `zsh`. For example: ```bash $ ls -1 notebooks...
@yasirroni This should be resolved by #148, but I haven't been able to test on Windows with PowerShell. If you have problems in that environment, please open a new issue.