Stan Rosenberg

Results 64 comments of Stan Rosenberg

> Thanks for the change! Just a suggestion, can we not make it in a single flag with enumeration? `always`, `default`, `never`? We could except we want the `default` to...

> So, it may be ok to keep to flags and remove "use-spot" later? We won't be able to remove "use-spot" because we need to allow for disabling spot usage,...

Removed `--use-spot-always` and augmented `--use-spot [never|always|auto]` as discussed. PTAL!

Another [smoke test](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/15349247?buildTab=log&logView=linear&focusLine=9346&linesState=196) with `SELECT_PROBABILITY=0.4`. Out of 50 selected with SpotVM, one failed with preemption.

TFTR! bors r=DarrylWong,herkolategan,nameisbhaskar

@herkolategan This is the mutex in `NewDNSProviderWithExec`, ``` return NewDNSProviderWithExec(func(cmd *exec.Cmd) ([]byte, error) { // Limit to one gcloud command at a time. At this time we are unsure if...

> but DNS records in particular don't matter. So, let's be more tolerant of such errors. They do now since DNS is also used as a discovery service for multi-tenant...

> I have not observed that, fwiw. But in any case, I'll send a revert; I didn't understand the implications. No worries. If it's a real issue for you, I...

> I've figured out my problem -- in https://github.com/cockroachdb/cockroach/pull/120340 there was confusion between the public DNS zone used for the A records, and the private DNS zone used for the...

Emulated "staleness" check which emits this warning in `roachprod`, ``` roachprod WARN: roachprod binary is >= 2 weeks old (569h7m14.325s); latest sha: "abcdef" WARN: Consider updating the binary: `roachprod update`...