Stan Rosenberg

Adding `gc_goopts = ["-d=libfuzzer"]` to your `go_test` rule ensures (edge) coverage is generated during compilation and subsequently used during fuzzing [1], ``` bazel run pkg/util:util_test -- -test.run notests -test.fuzz FuzzHex...

> This seems like way more work than it would be worth for what is, to be clear, a deprecated field. It's not _really_ a deprecated field despite having that...

> Do others think this approach is reasonable? I also played with [a different approach](https://github.com/cockroachdb/cockroach/compare/master...renatolabs:cockroach:rc/roachtest-fail-test-if-preempted) where roachtest continuously monitors for preempted VMs, but I think it's more general to have...

The sprawling changes to `test_runner` (and other `roachtest` infrastructure) introduced by this PR are a bit too sprawling for our comfort :) We'd prefer a cleaner approach, one that ideally...

Fixed by https://github.com/cockroachdb/cockroach/pull/124258

**NOTE**: there might be wrong assumptions in the code which assume that the underlying implementation of `uuid.MakeV4()` will produce zero collisions. One such assumption is in [1]. There are likely...

@cockroachdb/sql-foundations

As of `1.22`, `math/rand` is based on a crypto block cipher, namely `ChaCha8Rand` [1], > Using Go 1.22, the new ChaCha8Rand generator is seeded from 256 bits of entropy and...

I am guessing `check_generated_code` failed because you forgot to run, ``` ./dev generate bazel ``` which creates the missing `roachprod_test` package, ``` --- a/pkg/roachprod/BUILD.bazel +++ b/pkg/roachprod/BUILD.bazel @@ -1,4 +1,4 @@...

Tested the options `--use-spot=true`, `--use-spot=false` and `--use-spot-always=true` on my gceworker; no issues found. Triggered [GCE Run](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/15287726?buildTab=log&logView=linear&focusLine=34) in TC, with `SELECT_PROBABILITY=0.6` as a sanity check.