Sergei Rogovtcev

Results 12 comments of Sergei Rogovtcev

I think I can take this one myself, but I'd like to get an approval for the approach beforehand.

I've noticed that if only the `VersionDescription` is updated (without updating `CodeUri`), changeset contains only modifications to `Version` and `Alias`, and its execution fails with ``` Update to resource type...

I'll give it a try around the week end.

Am I right in understanding that as of `1.6.0` the `OTEL_TRACES_EXPORTER` variable is still not supported? I tried to find it in the code and couldn't.

> I'd have guessed that you'd get > ``` > Inner > Inner activated > Middle > Decorator > Outer > ``` To be completely honest, I originally expected `Activated`...

> this permits resolves that happen inside the `OnActivated` callback to make their own resolves without triggering circular reference errors. Yes, this is exactly what we do now: we resolve...

I'll try to, ahem, try this out later this week.

> by attaching to `ctxt.Operation.CurrentOperationEnding` in `OnActivated` instead of `ctxt.RequestCompleting` In short, it doesn't work this way: we don't have `IComponentContext` in `CurrentOperationEnding`, which we need to pass to `OnActivated`,...

Like this? ```cs ctxt.Operation.CurrentOperationEnding += (sender, evArgs) => { var surrogateContext = new DefaultResolveRequestContext(evArgs.ResolveOperation, evArgs.ResolveOperation.InitiatingRequest, evArgs.ResolveOperation.CurrentScope, evArgs.ResolveOperation.DiagnosticSource); var args = new ActivatedEventArgs(surrogateContext, ctxt.Service, ctxt.Registration, ctxt.Parameters, newInstance); handler(args); }; ``` Still...