Steven R. Loomis

Results 747 comments of Steven R. Loomis

hi @MuratKaribai it's rebased, let's make it work!

@btangmu As you can imagine, this PR from *may 2022* is more than a little bit bit-rotten… but I think it is a worthwhile effort, so I'm going to start...

Closing PR as author has closed the ticket.

@macchiati ticket here is marked as done?

@macchiati I think we've moved on and can close this.

> FWIW we strip out ICU break iterator data with small-icu > > https://github.com/nodejs/node/blob/bf3971673593ebd3f1f65b2d15a717f0784379ff/tools/icu/icu_small.json#L19 > > > https://github.com/nodejs/node/blob/bf3971673593ebd3f1f65b2d15a717f0784379ff/tools/icu/icu_small.json#L34-L40 > > Also https://bugs.chromium.org/p/v8/issues/detail?id=3345 referenced > > https://github.com/nodejs/node/blob/bf3971673593ebd3f1f65b2d15a717f0784379ff/tools/icu/icu-generic.gyp#L38-L41 > > cc @srl295...

> Apart from the PR for a regression test is someone also working towards fixing this? Will this be solved by adjusting the ICU configuration in NodeJS to include a...

> Alternatively the object should not exist on Intl we remove(d) it in some circumstances. Again i need to dig that out.

@abster Hi! Good to see you here. Yeah, can pick up the ICU dot release when it's available…

@abster wrote: > @Antonius-S From my understanding CLDR data can be updated on a specific ICU major release but updating CLDR data on a previous ICU release may not always...