node
node copied to clipboard
nodejs
Decimal and grouping separator for en-ZA does not align with in-country usage
What is the problem this feature will solve?
Currently, the built-in number and currency formatting libraries in Node.js return "," (comma) as decimal separator and " " (whitespace) as grouping separator for formatted numbers and currencies in en-ZA (English South Africa) locale.
console.log(new Intl.NumberFormat('en-ZA', { maximumSignificantDigits: 3 }).format(4.56));
// Expected output: "4.56"
// Actual output: "4,56"
console.log(new Intl.NumberFormat('en-ZA', { style: 'currency', currency: 'SAR' }).format(1234.56));
// Expected output: "SAR 1,234.56"
// Actual output: "SAR 1 234,56"
console.log(new IntlMessageFormat(
'The price is: {price, number, ::currency/SAR}',
'en-ZA'
).format({price: 1234.56}));
// Expected output: "The price is: SAR 1,234.56"
// Actual output: "The price is: SAR 1 234,56"
Officially, comma is the decimal separator and space is the grouping separator for numbers in en-ZA (https://www.sadev.co.za/content/how-correctly-format-currency-south-africa), however in common usage, price labels in shops, bank documents and statements use period (.) as decimal separator and comma (,) as grouping separator.
For context, check out following CLDR issues:
Decimal separator - South Africa Decimal and grouping separator for en_ZA does not align with in-country usage
What is the feature you are proposing to solve the problem?
Upgrade CLDR data in NodeJS. The fix for numbers and currencies in en-ZA locale from CLDR is set to be released as part of CLDR 43.1. This CLDR update will be integrated in an upcoming minor release for ICU4C/ICU4J. Node 20 currently uses ICU 73, while Node 18 (current stable release) uses ICU 72.
- Node 18 - Upgrade to ICU4C 73 and pick up the next minor release (when it is available) including the fix for numbers and currencies in en-ZA locale in CLDR 43.1.
- Node 20 - Pick up the next minor release for ICU4C 73 (when it is available) including the fix for numbers and currencies in en-ZA locale in CLDR 43.1.
What alternatives have you considered?
Create overrides in our consumer library. Unfortunately, it is not feasible for us to create overrides for every number and price formatting use case.
@abster Hi! Good to see you here. Yeah, can pick up the ICU dot release when it's available…
@abster meanwhile won't this help? https://nodejs.org/docs/latest-v19.x/api/intl.html#providing-icu-data-at-runtime
@Antonius-S From my understanding CLDR data can be updated on a specific ICU major release but updating CLDR data on a previous ICU release may not always be compatible, since CLDR releases are tied to specific ICU major releases.
Just as a heads-up, ICU 73.2 has been released: https://github.com/unicode-org/icu/releases/tag/release-73-2. Updating node.js to use ICU4C-73.2 should include the fix for en-ZA (addressed in CLDR issue).
To set expectations, our automation should pick up the new ICU release over the weekend. There's no reason to rush this any earlier as we won't be able to run the CI on it until the security releases are done next week.
@abster
@Antonius-S From my understanding CLDR data can be updated on a specific ICU major release but updating CLDR data on a previous ICU release may not always be compatible, since CLDR releases are tied to specific ICU major releases.
According to docs, for external ICU to work, the binary should be built with at most small-icu option so this is just a temporary workaround to solve the issue until new build is ready
@richardlau - I see that icu version is updated to 73.2 in the main branch: https://github.com/nodejs/node/blob/main/tools/icu/current_ver.dep
The latest minor release (v18.6.1) for node 18 is however still on 72.1. Do you know when node 18 would be updated to ICU 73.2?
https://github.com/nodejs/node/blob/v18.16.1/tools/icu/current_ver.dep
We usually want changes in a current release for at least two weeks before landing in LTS -- I see https://github.com/nodejs/node/pull/48502 only just recently went out in Node.js 20.4.0 so it might be a bit soon for the being prepared 18.17.0 (https://github.com/nodejs/node/pull/48694).
@richardlau - The latest minor release (v18.17.0) for node 18 is on ICU 73.1. Do you know when you expect node 18 to be updated to ICU 73.2?
Sometime in August according to the current plan in https://github.com/nodejs/Release/issues/737. May be a little clearer after tomorrow's working group meeting where we usually look at the schedules and see who's available to do releases https://github.com/nodejs/Release/issues/886.
@abster wrote:
@Antonius-S From my understanding CLDR data can be updated on a specific ICU major release but updating CLDR data on a previous ICU release may not always be compatible, since CLDR releases are tied to specific ICU major releases.
Hi…
Correct, prior ICUs cannot be upgraded to arbitrary CLDR versions. If there's enough interest/available hands to help, a CLDR fix could be back-ported to a prior CLDR maint line, which could then be picked up by the corresponding ICU maint line.
(v18.17.1) is on ICU 73.1. Is there a planned release for node 18, which will include update to ICU 73.2? Also, is there a target release date?
FYI @ruyadorno perhaps we can consider the ICU update (https://github.com/nodejs/node/pull/48502) for https://github.com/nodejs/node/pull/49220.
Looks like there was a change recently, and I see the two PRs above are merged. Is this done?
The ICU update has landed in all supported release lines, I’m going to assume this is fixed. Please comment or reopen if the issue still remains.