Steven R. Loomis
Steven R. Loomis
@dependabot recreate
@btangmu so i can either get the browser or the nonbrowser tests to work… probably what needs to happen is to bump webpack at the same time ( #2224 )...
just updating the brokenness !
@mcdurdin wanted to jump into kmc a little. Seems to work, but should ideally have a test/assertion
> I note the build failed, probably because binary data no longer matches for the e2e test (haven't investigated). Additional test would be good. yes that's why it's a draft....
> I note the build failed, probably because binary data no longer matches for the e2e test (haven't investigated). Additional test would be good. it was the e2e test fixture,...
trying this patch out… basically, making the 'gap' etc be a 0-length string ```diff diff --git a/common/web/types/src/kvk/kvk-file-writer.ts b/common/web/types/src/kvk/kvk-file-writer.ts index 78a484284..701b538b4 100644 --- a/common/web/types/src/kvk/kvk-file-writer.ts +++ b/common/web/types/src/kvk/kvk-file-writer.ts @@ -50,7 +50,11 @@ export...
actually one of the issues, elsewhere, was a non-gap key with no to (oops) ```xml ``` so perhaps on `!sourceKey.text` it should check if it's a gap, etc. and fail...
and yes this is the moving target problem !
> a bunch of other things to update mhm! done