Sebastian Rittau

Results 518 comments of Sebastian Rittau

@JelleZijlstra CI fails, at the moment, so we shouldn't merge.

Today I learned that "ujson" is "UltraJSON", not "MicroJSON". Anyway, I think this issue is complete. stubsabot will notify us, once a new version with type stubs gets released.

Maybe we could revisit #8789? Seems like a mypy problem that may or may not be fixed in the meantime, but should probably be fixed in any case.

As the linked PR shows, there's a conflict between what the abstract base class supports and what the (virtual) set protocol (which should be represented by `collections.abc.Set`) supports. It's unfortunate...

> I only found a couple of other places in `stubs/channels/` where I was confident in weakening list parameter types to something covariant. One of them could be a `Collection`,...

It makes sense to me to modernize the instructions to use `pyproject.toml`.

This seems useful. In fact, I don't know why we're using `Any` at all here.

See also an experimental PR I opened a while back: #11844. I'll resurrect it and see what the current situation is. Also discussed in python/typing#1962.

I have no experience with pandas, so I can't really comment on this issue, but a PR outlining the change you desire would be very welcome.

We should merge #13840 first and then let stubsabot do its thing again.