Sebastian Rittau
Sebastian Rittau
@max-muoto Thanks for doing this! Maybe it's easier to start smaller. E.g. start with a PR that changes only protocols or a PR that only changes stdlib/io.pyi. That said, overall...
Please note that your example won't work at runtime (using redis 4.6.0): ```python import redis r = redis.Redis.from_url( url="redis://", health_check_interval=3, ssl_ca_data="aaa", ) r.get("aa") ``` ``` Traceback (most recent call last):...
Ah, that makes sense. So we should probably add the arguments to `SSLConnection` as well, or just add `**kwargs: Any`. (With an appropriate comment in either case.) PR welcome!
If a release is planned soon, #19020 would get Python 3.14 in typeshed over the finish line.
In fact, it seems it's always an `re.Pattern` (if not `None`). PR welcome!
One thing to note is that currently the PyMySQL stubs just use `from . import constants` instead of `from . import constants as constants`. We're changing that, although that still...
Possibly add a version and a platform check. But considering that this is simply a (fixed) bug in the stdlib, I'd be fine with doing nothing.
I'm honestly wary to allow arbitrary floats here as using them could lead to bugs due to floating point math. I would suggest to use a big int instead, e.g....
For the record, the `Collection` class is not necessary to expose the problem: ```python from typing import Self class Base1: def foo(self) -> Self: return self class Base2: def foo(self)...
That sounds promising!