Sebastian Rittau

Results 518 comments of Sebastian Rittau

Thanks for contributing! I'm closing this PR for now, because it still fails some tests and has unresolved review feedbackafter three months of inactivity. If you are still interested, please...

I'm not sure we need the fake class. From what I understand, the inheritance hierarchy at runtime is `Pattern` → `InlineProcessor` →`SomeDerivedProcessor`, where `InlineProcessor` has an incompatible `handleMatch` signature, compared...

I would prefer if we copy the distutils stubs into setuptools. From what I understand, they are different from stdlib's distutils at this point anyway, and may evolve further. I'd...

Does it still use an import hack? At least the freshly installed version of setuptools (68.2.2) vendors distutils and does seem to use it: ``` Python 3.11.4 (main, Jun 9...

But `setuptools.distutils` is equivalent to `setuptools._distutils`, at least in my tests: System Python: ``` Python 3.11.4 (main, Jun 9 2023, 07:59:55) [GCC 12.3.0] on linux Type "help", "copyright", "credits" or...

I don't have much to contribute, but note that the underlying problem is users using `list[...]` as an argument annotation. This is understandable as it's the most obvious and ergonomic...

> > One possible solution is to omit the `LiteralString` overloads for these three methods. This would eliminate the type violation error in the common case, but it would introduce...

Thanks for opening this! What would be the effect if someone uses a stub with mypy that uses this feature without `--enable-incomplete-feature`? Will it be treated as `Any` or will...

I've merged in the existing changes, but this might have introduces new problems, since some changes were incompatible.

I assume that this was introduced in python/typeshed#8330 by @hauntsaninja. Before that PR, the fourth overload was matched, which just returned `Any` from `Value()`, now the second overload is (correctly)...