Sebastian Rittau

Results 518 comments of Sebastian Rittau

Generally we try to follow the actual implementation, until there is a good reason not to. Typing private modules is "better", but it was often neglected, because practically speaking there...

TypeVar defaults are now available in typeshed.

See #11422 for the type var generics feature tracker.

TypeVar defaults are now available in typeshed.

If I remember correctly, the METADATA files are mainly included for reference or potential use by tooling and have no runtime impact apart from that.

I see a few options, but I'd be interested in what others think. 1. As suggested by @mr-c, rename the metadata files to include the package name. For consistency's sake,...

I looked into that, but accroding to the [packaging docs](https://packaging.python.org/en/latest/specifications/recording-installed-packages/), this may not be allowed: > This .dist-info directory may contain the following files, described in detail below: I understand...

> I understand this to mean that the list is exhaustive, although we could ask the PyPA. https://discuss.python.org/t/extra-files-in-dist-info/39418

It seems that - while not officially supported - adding extra files to `.dist-info` is not officially supported, it is tolerated. I don't think we should name the file `METADATA.toml`,...

That applies to `Action.type` as well. A type alias `_ActionType` might be a good idea here. Any PRs welcome!